Closed SukkaW closed 10 months ago
Yeah; that'd be great. It's a ton of work, but if you want to take a stab at it, you're more than welcome to! Just please make granular PRs; not one gigantic PR that takes hours to review.
Yeah; that'd be great. It's a ton of work, but if you want to take a stab at it, you're more than welcome to! Just please make granular PRs; not one gigantic PR that takes hours to review.
Sure! Let's do one API migration per PR. And I can make each PR safe to even be included in a minor version bump (a.k.a. No breaking changes!).
I will list the roadmap here for progress tracking:
copy
: #1021empty
: The emptyDir
's implementation is already Promise-based, see #885ensure
: https://github.com/jprichardson/node-fs-extra/pull/1023json
: The json
is just a re-export of jsonfile
modulemkdirs
: The mkdirs
's implementation is already Promise-basedmove
: https://github.com/jprichardson/node-fs-extra/pull/1025output-file
: https://github.com/jprichardson/node-fs-extra/pull/1024path-exists
: The pathExists
's implementation is already Promise-basedremove
: The remove
is just a simple wrapper of graceful-fs#rm
, no need to refactorClosing as this is now completed. Thanks again for all your efforts here!
We can use
async
andawait
to organize the codebase anduniversalify.fromPromise
to create Node.js-callback style APIs from the promise-based APIs.