jprichardson / node-fs-extra

Node.js: extra methods for the fs object like copy(), remove(), mkdirs()
MIT License
9.43k stars 775 forks source link

[Proposal] Refactor the entire code base to Promise-based #1020

Closed SukkaW closed 10 months ago

SukkaW commented 10 months ago

We can use async and await to organize the codebase and universalify.fromPromise to create Node.js-callback style APIs from the promise-based APIs.

RyanZim commented 10 months ago

Yeah; that'd be great. It's a ton of work, but if you want to take a stab at it, you're more than welcome to! Just please make granular PRs; not one gigantic PR that takes hours to review.

SukkaW commented 10 months ago

Yeah; that'd be great. It's a ton of work, but if you want to take a stab at it, you're more than welcome to! Just please make granular PRs; not one gigantic PR that takes hours to review.


Sure! Let's do one API migration per PR. And I can make each PR safe to even be included in a minor version bump (a.k.a. No breaking changes!).

I will list the roadmap here for progress tracking:

RyanZim commented 10 months ago

Closing as this is now completed. Thanks again for all your efforts here!