Allow passing undefined options to move()

jprichardson / node-fs-extra

Node.js: extra methods for the fs object like copy(), remove(), mkdirs()

MIT License

9.44k stars 776 forks source link

Closed Nokel81 closed 2 years ago

Nokel81 commented 2 years ago

fixes #947

I thought about adding a test but then couldn't find any tests of a similar nature within the repo so I didn't. I can if it is thought to be useful.

Nokel81 commented 2 years ago

I have fixed the implementation to work with the existing tests and decided to add a unit test to cover this use case as well.

RyanZim commented 2 years ago

Tests are failing; haven't looked into it in detail.

RyanZim commented 2 years ago

Created https://github.com/jprichardson/node-fs-extra/pull/955; which doesn't have the extra parameter validation, and has simpler tests.