search

jprichardson / node-fs-extra

Node.js: extra methods for the fs object like copy(), remove(), mkdirs()
MIT License
9.44k stars 776 forks source link

filter property in options object is not called for every copied file when recursive option is true #988

Closed FreePhoenix888 closed 1 year ago

FreePhoenix888 commented 1 year ago

Expected

copySync with recursive: true in options object calls filter with every file which is being copied

Actual

copySync with recursive: true in options object calls filter with only src and dest directory paths

RyanZim commented 1 year ago

Huh, I wonder when this broke. We should definitely have a unit test for this; if you've got a chance, a PR with a failing unit test would be greatly appreciated. Otherwise, I'll try to get to this soon.

FreePhoenix888 commented 1 year ago

@RyanZim , https://github.com/jprichardson/node-fs-extra/pull/989

RyanZim commented 1 year ago

Closing as per https://github.com/jprichardson/node-fs-extra/pull/989#issuecomment-1365399194.