search

jprichardson / node-fs-extra

Node.js: extra methods for the fs object like copy(), remove(), mkdirs()
MIT License
9.44k stars 776 forks source link

Create copySync.test.js #989

Closed FreePhoenix888 closed 1 year ago

FreePhoenix888 commented 1 year ago

https://github.com/jprichardson/node-fs-extra/issues/988

FreePhoenix888 commented 1 year ago

@RyanZim , which of them are warnings and which of them are errors? https://github.com/jprichardson/node-fs-extra/actions/runs/3770641872/jobs/6413789692#step:5:13 I have fixed this problem: https://github.com/jprichardson/node-fs-extra/actions/runs/3770641872/jobs/6413789692#step:5:24

If other things are errors and must be processed - could not you please do it? You are allowed to edit this pull request: image

RyanZim commented 1 year ago

I finally got a chance to look at this and test in detail. fs-extra is working as intended here. First, the actual source and dest directory are passed to the filter. If the filter returns false, we stop copying, and make no further calls to filter. However, if it returns true, filter is called with each file in the directory.