Closed KostiantynPopovych closed 1 year ago
Hey @RyanZim, I updated the implementation to match the logic that was discussed in thread #992. I refactored a bit methods move & moveSync to match the same style.
It's not clear to me why the large refactor is needed; theoretically you only need to set preserveTimestamps
in moveAcrossDevice
, similarly to how errorOnExist
is currently set. What am I missing?
@RyanZim Reverted original code, that refactoring might be overengineering for now 🤔
Thank you for reviewing it!
This PR resolves issue: #992.
These test files are pretty similar, I just took the
copy
method test files as a blueprint, and it seems we can make some refactoring here and there. I'm open to any suggestions!