search

jprichardson / node-jsonfile

Easily read/write JSON files.
MIT License
1.2k stars 321 forks source link

Add architecture ppc64le to travis build #142

Closed rajesh-ibm-power closed 3 years ago

rajesh-ibm-power commented 3 years ago

Hi, I had added ppc64le(Linux on Power) architecture support on Travis-CI in the PR and looks like its been successfully added. I believe it is ready for the final review and merge. The Travis-CI build logs can be verified from the link below. https://travis-ci.com/github/rajesh-ibm-power/node-jsonfile Reason behind running tests on ppc64le: This package is included in the ppc64le versions of RHEL and Ubuntu - this allows the top of tree to be tested continuously as it is for Intel, making it easier to catch any possible regressions on ppc64le before the distros begin their clones and builds. This reduces the work in integrating this package into future versions of RHEL/Ubuntu. Please have a look.

Thank you

RyanZim commented 3 years ago

There is no case where system arch should affect test results in any way; no need to waste CI resources with this.