search

jprichardson / node-jsonfile

Easily read/write JSON files.
MIT License
1.2k stars 321 forks source link

should include "fs" as a dependency #56

Closed hobberwickey closed 7 years ago

hobberwickey commented 8 years ago

I realize most everyone will have this already installed, but it is imported so you might want to add it as a dependency.

jprichardson commented 8 years ago

fs is not a 3rd party module, so why would it need to be a dependency?

hobberwickey commented 8 years ago

That's what I assumed too, but for some reason I needed to explicitly install it. Node v5.10.1

jprichardson commented 8 years ago

That's what I assumed too

It's not an assumption. fs is part of Node.js core.

but for some reason I needed to explicitly install it

You should figure out what that reason is.

RyanZim commented 7 years ago

As stated above, fs is a core module; no need to depend on it. Closing.