search

jprichardson / node-klaw

A Node.js file system walker with a Readable stream interface. Extracted from fs-extra.
MIT License
317 stars 41 forks source link

Sort #33

Closed tomhughes closed 5 years ago

tomhughes commented 5 years ago

Sort comparators are supposed to return a tristate value not just a boolean, but apparently this was more or less accidentally working.

The new sort algorithm in v8 7.x as used in Node 12.x didn't like it though and was giving the wrong results.

RyanZim commented 5 years ago

Sorry for leaving this sit, somehow it slipped through the cracks. Tests will be fixed after https://github.com/jprichardson/node-klaw/pull/35 is merged.