search

jprichardson / node-klaw

A Node.js file system walker with a Readable stream interface. Extracted from fs-extra.
MIT License
317 stars 41 forks source link

modernize (const, let, class, update dep, etc) #43

Closed jimmywarting closed 3 years ago

jimmywarting commented 3 years ago
RyanZim commented 3 years ago

This removes graceful-fs, curious what the reasoning was?

jimmywarting commented 3 years ago

Didn't see graceful-fs as needed... fewer dependencies. less to install, faster to start.

RyanZim commented 3 years ago

Sorry for the slow review here; just got out of the hospital. I'm OK with removing graceful-fs.

jimmywarting commented 3 years ago

Sorry for the slow review here; just got out of the hospital. I'm OK with removing graceful-fs.

Oh, hope you are better now. I removed the lock file and @types/node

RyanZim commented 3 years ago

Landed in 8fbf2d26a2b7f46dce7915052d25947ce6b9a0d2; thanks!