jprichardson / string.js

Extra JavaScript string methods.
http://stringjs.com
1.81k stars 234 forks source link

What if I don't want humanize() to strip "id"? #199

Open wellguimaraes opened 8 years ago

wellguimaraes commented 8 years ago

Would't it be better if humanize() left "id"s on the result string? So if I really need to remove "id"s, a simple replace before humanizing would solve.

codeandcats commented 7 years ago

Agree exactly.

But can't remove it now without a major version bump as it would introduce potential breaking changes. I recommend humanize accepts an optional options object with a removeTrailingId field that is true by default. Then make it false by default in the next major version.

I would submit the PR myself but I get the feeling this repo is not being actively maintained?

jprichardson commented 7 years ago

I would submit the PR myself but I get the feeling this repo is not being actively maintained?

Unfortunately not. Submit a few PRs, and you can be the maintainer of an open-source project 😉