search

jprichardson / tin

Easily manage package.json, component.json, and bower.json files.
MIT License
92 stars 4 forks source link

fix keywords #10

Closed calvinmetcalf closed 10 years ago

calvinmetcalf commented 10 years ago

you try to create the keywords array by concating the words array to the (not yet created) keyword array

jprichardson commented 10 years ago

I must be missing what you're trying to do... it's intentional behavior to concatenate to the array. Are you experiencing an error?

calvinmetcalf commented 10 years ago

you are trying to concat data to the array data.keywords before data.keywords exists, or will be able to exist as far as I can tell.

jprichardson commented 10 years ago

Ahh, I see. Your fix removes the concat behavior... I'll modify it. Thanks.

calvinmetcalf commented 10 years ago

I removed it because as far as I could tell it would never need to be concated right there

On Mon, Dec 2, 2013 at 8:49 AM, JP Richardson notifications@github.comwrote:

Ahh, I see. Your fix removes the concat behavior... I'll modify it. Thanks it.

— Reply to this email directly or view it on GitHubhttps://github.com/jprichardson/tin/pull/10#issuecomment-29618514 .

-Calvin W. Metcalf

jprichardson commented 10 years ago

Fixed it. Didn't accept the PR because it removed the concat ability. Thanks so much for your interest and for pointing out the bug!