jprider63 / vrdt

5 stars 0 forks source link

Dev.jp #1

Closed jprider63 closed 4 years ago

jprider63 commented 4 years ago

I split things into separate packages. I'll probably work on this more tonight, but you can check things out as is.

plredmond commented 4 years ago

I want to reiterate that I don't think splitting up into three packages gives us anything. These three packages are tightly coupled, and we are still actively developing the code. Splitting them up makes working on them more difficult. The tools (both stack and cabal) have flaky support here (eg. try running stack --file-watch build in both core and client and watch it fail to lock resources correctly). If you want to add/remove a dependency, now you have to consider whether it needs to be added/removed from one of the other packages too.

Since you left out the package.yaml/*.cabal files I'm not sure exactly how many dependencies are potentially saved by potential users of kwik-core. In any case, I don't think this is the right move at this point in the development, especially considering this is a proof-of-concept to showcase the VRDT package.

jprider63 commented 4 years ago

Sorry about the cabal files. The .gitignore hid them.

I changed it to a single stack.yaml, and stack build --file-watch works consistently for me. Does that work for you?