search

jpriebe / google-maps-gl-style

A Mapbox GL basemap style designed to look like Google Maps
5 stars 5 forks source link

Capital filters not the same #2

Open dawkre opened 3 years ago

dawkre commented 3 years ago

Hi @jpriebe, thanks for the style. I really like it! I had this issue that it wasn't showing Warsaw - the capital of Poland for me. I've noticed that in one place, "capital" is being filtered out like this ["!=", "capital", 2] and then in another place, the filter is ["==", "capital", 4].

The capital started showing on the map for me after I changed the 4 to 2. Not sure if it's intended, so raising it here. Thanks

jpriebe commented 3 years ago

Glad you like it. I'm too far removed from this work to be able to maintain this (I don't run a mapping application where I can test your changes). If you want to submit a pull request (and maybe some before/after screenshots), I would be happy to merge in your fix.

On Sat, Mar 20, 2021 at 12:04 PM dawkre @.***> wrote:

Hi @jpriebe https://github.com/jpriebe, thanks for the style. I really like it! I had this issue that it wasn't showing Warsaw - the capital of Poland for me. I've noticed that in one place, "capital" is being filtered out like this ["!=", "capital", 2] and then in another place, the filter is ["==", "capital", 4].

The capital started showing on the map for me after I changed the 4 to 2. Not sure if it's intended, so raising it here. Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jpriebe/google-maps-gl-style/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU6FSCMWE2HEKWVZ6WTKY3TETBPLANCNFSM4ZQR477Q .

--

-Jason