search

jprjr / multistreamer

[discontinued] A webapp for publishing video to multiple streaming services at once.
MIT License
322 stars 94 forks source link

Stop puller doesn't kill ffmpeg process #16

Closed bugz8unny69 closed 5 years ago

bugz8unny69 commented 7 years ago

Steps to reproduce:

  1. Create a new stream with custom ffmepg arguments
  2. Head over to Edit Metadata and start puller
  3. Wait a few minutes and click Stop puller

While the page refreshes and appears that the ffmpeg puller has stopped. The stream preview is still showing content and the ffmpeg processes are still running. At this point, you are no longer able to stop the ffmpeg process through the Web UI, only launch a new ffmpeg process.

jprjr commented 7 years ago

I had actually just discovered this last night!

I'm working on re-doing the process management code to properly send ffmpeg the 'quit' command instead of relying on sockexec to notice the connection is gone, which will fix this problem.

Additionally, I'm going to have each pusher get its own process, instead of having a single ffmpeg process for all outputs. Then it will be possible to add/remove accounts while streaming, stop individual outputs, and so on.

jprjr commented 7 years ago

So I've pushed 9.0.0 which fixes this problem - but I held off on the "stop individual processes" feature for now, I'll get that coded up in a future release.