Allow the subjective judges to state "FINAL" - Githubissues

jpschewe / fll-sw

FIRST Lego League scoring software

http://jpschewe.github.io/fll-sw/

GNU General Public License v2.0

10 stars 7 forks source link

Allow the subjective judges to state "FINAL" #1172

Closed jpschewe closed 3 months ago

jpschewe commented 5 months ago

When synchronizing scores, prompt the judge if this is the "FINAL scores for ALL teams". Store this in the database and display on the summarizePhase1.jsp page. Remind judges that they can still update comments, however if changing scores after this to make sure to let the head judge know.

jpschewe commented 3 months ago

Plan to add boolean to the judges table named "final". This value defaults to false and is set based on a message from the subjective web application.

The upload button will need a modal dialog prompting for an answer if all scores for this judge are final.

jpschewe commented 3 months ago

Database changes in place and UI in place. Items left to do

[x] Figure out what to do with VerifyJudges where JudgeInformation is constructed. Need to make sure that I don't loose the finalScores state
[x] Need to rework subjective_module._currentJudge to store only the judge ID and then to do a lookup when needed.

jpschewe commented 3 months ago

[x] don't show the final dialog when no judge is selected

jpschewe commented 3 months ago

[x] display judge final scores flag on the summarize scores page

jpschewe commented 3 months ago

I've implemented both options for how the judges select final and have requested feedback on which version to use.