search

jpschewe / fll-sw

FIRST Lego League scoring software
http://jpschewe.github.io/fll-sw/
GNU General Public License v2.0
10 stars 7 forks source link

Error when adding scores for Fun run #956

Closed jeanniebadger closed 3 years ago

jeanniebadger commented 3 years ago

I went through and entered scores for Runs 1-3

When trying to access team for Run 4 "Fun Run" received this error and bug report

Error messages:

Cannot find playoff bracket for team 4285 run number 4 in tournament 0

Was I supposed to change this parameter before I started to allow for 4 runs? Can't remember what we did 2 years ago

image

bug_2021-07-12_14-0210702809836545661742.zip

jpschewe commented 3 years ago

@jeanniebadger yes, you need to have "Running head to head" unchecked before any performance rounds are entered.

jeanniebadger commented 3 years ago

@jpschewe I was actually referring to number of performance round - should that have been 4

jpschewe commented 3 years ago

@jeanniebadger no, there should only be 3 performance rounds, otherwise the "Fun Run" would effect the reports.

jpschewe commented 3 years ago

@jeanniebadger I'm looking at the code and I don't see how this worked before. The latest set of changes around this are from November of 2019. Maybe the checkbox for running head to head didn't quite work right that season and we fell back to the work around where we initialize brackets, but never display them. I just made a change that I think will fix this. In about an hour please give the release at https://jenkins.mtu.net/job/FLL-SW/job/issue%252F956%252Ffun-run/ a try.

jeanniebadger commented 3 years ago

Jon - I was able to use the new release and enter scores for additional rounds.

It appears that the 4th run (Fun Run) was in team number order, not time order. But I think we can live with that.

jpschewe commented 3 years ago

Glad to hear that worked. I would have expected the teams to be in schedule order if the 4th round was in the schedule.

jeanniebadger commented 3 years ago

Yes, I thought they would be in schedule order as well. I will run again and double check

On Tue, Jul 13, 2021 at 2:55 PM Jon Schewe @.***> wrote:

Glad to hear that worked. I would have expected the teams to be in schedule order if the 4th round was in the schedule.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jpschewe/fll-sw/issues/956#issuecomment-879359305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5OHMMDGHBESEXCXEQX4P3TXSK3LANCNFSM5AHOFZLQ .

--

Jeannie Badger

Programming Trainer

We moved on May 1, 2021 - Please note our new address

3370 Coachman Road, Suite D Eagan, MN 55121

612.781.2203 www.hightechkids.org

Check out our latest program offering - CoderZ https://coderzleague.com/?utm_source=HighTechKids&utm_medium=Minisite&utm_campaign=Coderz_League

http://www.hightechkids.org/

jeanniebadger commented 3 years ago

Here is a pic of the schedule for Fun Run - using database with 4 teams. Tournament is attached

[image: image.png]

This is the schedule showing up on Score Entry after 3 runs have been entered.

[image: image.png]

This shows that all 12 runs were entered in order

[image: image.png]

On Tue, Jul 13, 2021 at 4:50 PM Jeannie Badger @.***> wrote:

Yes, I thought they would be in schedule order as well. I will run again and double check

On Tue, Jul 13, 2021 at 2:55 PM Jon Schewe @.***> wrote:

Glad to hear that worked. I would have expected the teams to be in schedule order if the 4th round was in the schedule.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jpschewe/fll-sw/issues/956#issuecomment-879359305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5OHMMDGHBESEXCXEQX4P3TXSK3LANCNFSM5AHOFZLQ .

--

Jeannie Badger

Programming Trainer

We moved on May 1, 2021 - Please note our new address

3370 Coachman Road, Suite D Eagan, MN 55121

612.781.2203 www.hightechkids.org

Check out our latest program offering - CoderZ https://coderzleague.com/?utm_source=HighTechKids&utm_medium=Minisite&utm_campaign=Coderz_League

http://www.hightechkids.org/

--

Jeannie Badger

Programming Trainer

We moved on May 1, 2021 - Please note our new address

3370 Coachman Road, Suite D Eagan, MN 55121

612.781.2203 www.hightechkids.org

Check out our latest program offering - CoderZ https://coderzleague.com/?utm_source=HighTechKids&utm_medium=Minisite&utm_campaign=Coderz_League

http://www.hightechkids.org/

jpschewe commented 3 years ago

Can you attach the database to the ticket? Also note that the images in an email don't get added to the ticket.

jeanniebadger commented 3 years ago

TestSmallPriorLake.xlsx I will email you the xml since I don't know how to attach it here :-)

jpschewe commented 3 years ago

@jeanniebadger I just looked at your schedule. I see the problem. The "fun run" columns won't get picked up as performance rounds because you didn't name them using the same pattern. The software only considers columns that match "Perf #%d" and "Perf %d Table" the the round time and table columns where "%d" is replaced by the run number.