search

jpsider / RestPS

Simple ReST Framework for Powershell
MIT License
112 stars 30 forks source link

Support Get Process by PID #57

Closed robinmalik closed 3 years ago

robinmalik commented 3 years ago

Support Get Process by PID. We required this ability at work, and I thought it'd be a useful option to have in the module.

jpsider commented 3 years ago

Are you able to see the log from Appveyor for the failure?

robinmalik commented 3 years ago

Yes:

ERROR: Cannot bind argument to parameter 'CoverallsApiToken' because it is an empty string.
At C:\projects\restps\module.build.ps1:33 char:80
+ ... terResults $TestResults -CoverallsApiToken $ENV:Coveralls_Key -Branch ...
+                                                ~~~~~~~~~~~~~~~~~~
At C:\projects\restps\module.build.ps1:31 char:1
+ Task Publish_Unit_Tests_Coverage {
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
At C:\projects\restps\module.build.ps1:16 char:1
+ Task Pester Build, ImportModule, UnitTests, FullTests, Publish_Unit_T ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
At C:\projects\restps\module.build.ps1:14 char:1
+ Task Default Build, Pester, UpdateSource, Publish
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Build FAILED. 11 tasks, 1 errors, 0 warnings 00:02:13.1392551
Cannot bind argument to parameter 'CoverallsApiToken' because it is an empty string.

I don't understand it though (it doesn't appear related to any change I made). Are you able to elaborate on this?

jpsider commented 3 years ago

I can take a look at it a bit later today, I'm about to hop on a plane for a couple hours.

robinmalik commented 3 years ago

@jpsider No rush at all :)

jpsider commented 3 years ago

Build worked for me, I will deploy it to the Gallery in a little bit.

jpsider commented 3 years ago

Package published - RestPS 7.0.40

robinmalik commented 3 years ago

That's great, thanks (though in retrospect I wonder if it should have been "id" rather than "pid" - oversight in bolting this functionality on for a specific job at work).

For future reference, is there anything that can be done to avoid getting AppVeyor failures and you having to manually run tests? It seems like a pain for you, for such minor tweaks to the module.

jpsider commented 3 years ago

It's all good. I didn't actually do anything. The error you saw was caused by a environmental variable I think.