Image Loaded async from URL + Various fixes

jpsim / JPSThumbnailAnnotation

A simple mapkit annotation for displaying images and details.

http://jpsim.com/JPSThumbnailAnnotation

MIT License

473 stars 78 forks source link

Image Loaded async from URL + Various fixes #28

Closed ogonzalezadell closed 7 years ago

ogonzalezadell commented 7 years ago

This Pull request adds de following changes:

Fix JPSThumbnailAnnotationView frame not beeing placed properly.
Fix JPSThumnail.m class name (misspell) to JPSThumbnail
Added SDWebImage (simple way) with activity indicator (no extra package dependencies as #18)
Updated Readme
Updated Podspec to add SDWebImage and update to version 1.1.0
Updated Project Demo
Added Content mode type to thumbs, by default AspectFill

jpsim commented 7 years ago

Thanks for your hard work on this @ogonzalezadell. Could you please break up this PR into smaller PRs that each just do one thing? That'll greatly simplify reviewing everything, merge the obviously correct stuff and help me focus on the things that actually need attention and discussion.

ogonzalezadell commented 7 years ago

Hi @jpsim, thanks for your response, I'm a bit new to this but will try to separate everything in different PR this week if I find some time.

ogonzalezadell commented 7 years ago

The last pull request is #33, once accepted I will remove this one

Thanks