Fix some bugs in allowing to start/and/stop the handler

jpsim / JPSVolumeButtonHandler

JPSVolumeButtonHandler provides an easy block interface to hardware volume buttons on iOS devices. Perfect for camera apps!

MIT License

333 stars 90 forks source link

Fix some bugs in allowing to start/and/stop the handler #33

Closed samyes closed 7 years ago

samyes commented 7 years ago

If at full volume while initializing, the system HUD would sometimes incorrectly display the volume initialization back down to 0.99
In some cases (seemed to repro consistently on later iOS versions), the volume was being incorrectly reset to either 0 or 0.5

jpsim commented 7 years ago

Code changes look good, but I haven't run myself to test. Assuming you're making these changes for a reason 😄

Thanks for the PR!

samyes commented 7 years ago

Thanks! Making/testing the parallel changes in our local branch 😛

jpsim commented 7 years ago

I appreciate the contributions you've been making to this project, I've made you a collaborator to make it easier for you to continue your work on this, when necessary. Feel free to merge your own PRs unless you're explicitly soliciting reviews 😄

samyes commented 7 years ago

SGTM ✔