jpsim / JPSVolumeButtonHandler

JPSVolumeButtonHandler provides an easy block interface to hardware volume buttons on iOS devices. Perfect for camera apps!
MIT License
336 stars 91 forks source link

Initialization prevents bluetooth audio playback #46

Closed apple-ihack-geek closed 7 years ago

apple-ihack-geek commented 7 years ago

Whenever I start JPSVolumeButtonHandler, sadly bluetooth audio playback stops. I tried setting the option for "AVAudioSessionCategoryOptionAllowBluetooth" but sadly it made no difference. Any idea how best to resolve this? Thanks.

CallumOz commented 7 years ago

Same problem here. Using version 1.0.1, I had no problems. I have reverted to this older version for the time being.

jpsim commented 7 years ago

There's a larger problem here where I'm not actively maintaining this library, I've just been merging PRs and pushing releases.

So I depend on contributors filing PRs to be diligent in preventing compatibility issues with previous versions, but no one (myself included) has really taken the responsibility of ensuring this library remains high quality.

I'd like to invite any active users interested in helping maintain, or even take over, this library to please let me know. It's obviously a library that's still somewhat actively used, so it deserves a bit of regular maintenance love and care 😄

apple-ihack-geek commented 7 years ago

@CallumOz This should fix our issues. @jpsim I can help review people's PRs, but someone should be reviewing mine too (since I've been on a roll lately ;) ) , so maybe add me and one other person, make master branch protected, and then that way at least one of the three of us has to approve.

CallumOz commented 7 years ago

Thanks for the hard work @apple-ihack-geek! It works great during audio playback to a bluetooth device. However the handler's aren't called during Bluetooth streaming, and the volume buttons change the Bluetooth audio volume instead. In version 1.0.1, the handlers are called even when streaming Bluetooth audio and don't change the volume.

I'm not complaining, I'm juste wondering what has changed.

Edit: It works during Bluetooth audio playback, I forgot to start it 😝