search

jpsim / JPSVolumeButtonHandler

JPSVolumeButtonHandler provides an easy block interface to hardware volume buttons on iOS devices. Perfect for camera apps!
MIT License
336 stars 91 forks source link

Is it allowed? #60

Open AT-MAK opened 6 years ago

AT-MAK commented 6 years ago

Hi there thank you very mich jps for providing your code. Point is, I‘m at the end of m app‘s development.It‘s a game and release is planned near the end of june. It works all great but now worries start to come that apple could eventually ban it. But please give me some hope. This code should be fine to apple,or? And besides that, the usage of the volume buttons is NOT mandatory in my game but provide help. And lets be honest for some games the buttons are great. Is there a chance that apple will accept my game as it is cause the button feature is great and if people dont like it-they dont have to. Is this a good reason to keep it? Besides that: Camera apps make use of the buttons(IF a cameraman wants it he can smash the button like crazy), a few stop watch apps also have this feature implementet. Apple should not come to me and say that their (the other apps) usage of the buttons is less and therefore „healthy and accepteable“. My game is as well. Thank‘s for reading.

Ps i found this online : https://forum.unity.com/threads/using-volume-buttons-as-additional-controls-in-game.153966/

It seems like apps have been rejected because they used some sort of private api. Is jpsvolumebuttonhandler with a public api- therefore the chances of being rejected should be minimal?

jpsim commented 6 years ago

This only uses public APIs.

AT-MAK commented 6 years ago

Ok. Do you know any app that uses your code so that i can be relatively shure that apple won't reject mine? Do you have any experience mattering this? Still,thanks man you're the best

jpsim commented 6 years ago

Ok. Do you know any app that uses your code so that i can be relatively sure that apple won't reject mine?

I don't know which apps use this library. I know at one point probably not anymore Snapchat used this.

Do you have any experience mattering this?

I review and merge pull requests, but I don't actively use this myself anymore.

sungholee3526 commented 5 years ago

I know it's a bit late but my app passed the review just fine with this library.

https://itunes.apple.com/us/app/easy-counter-set-your-goal/id832360460?l=ko&ls=1&mt=8

AT-MAK commented 5 years ago

Hey sh1217sh, nice that it passed! My app also passed 4 months ago ;) https://itunes.apple.com/de/app/ezy/id1395389722?l=en&mt=8 Again, thank you jpsim. It would not be the game it should be without you providing your code!