search

jpsim / PeerKit

An open-source Swift framework for building event-driven, zero-config Multipeer Connectivity apps
MIT License
870 stars 72 forks source link

Swift 2.0 changes #14

Closed alexanderjarvis closed 9 years ago

alexanderjarvis commented 9 years ago

Includes fixes from the migration tool + other xcode things + something to make it actually compile instead of seg fault due to correct function sigs.

jpsim commented 9 years ago

Thanks for this, @alexanderjarvis! Everything here looks great, minus the one place where there could be a guard rather than the big if let.

alexanderjarvis commented 9 years ago

Done!

I'm not 100% sure guard is a good thing :tm: because I'm used to "everything is an expression" from Scala. Sure it lets you prevent some nesting which is handy, but it feels more imperative than functional with the early exit and explicit return.

jpsim commented 9 years ago

Thanks!