search

jpsim / Yams

A Sweet and Swifty YAML parser.
https://jpsim.com/Yams
MIT License
1.12k stars 144 forks source link

Implement Anchor coding, Tag coding and redundancy auto-aliasing #428

Open lynchsft opened 2 months ago

lynchsft commented 2 months ago
lynchsft commented 2 months ago

@jpsim is it intended configuration that the workflows won't run without a maintainer approving? I would have loved to validated that all builds succeeded before bugging you. 🙏🏻

lynchsft commented 1 month ago

I see the failed checks and will work to resolve them. :) 🙏🏻

lynchsft commented 1 month ago

The pod lib lint failed because of a workflow/host misconfiguration.

ERROR | [visionOS] unknown: Encountered an unknown error (Could not find axrossimulator (valid values: ios, tvos, watchos). Ensure that Xcode -> Window -> Devices has at least onexrossimulator listed or otherwise add one.

IIRC xros was a preview-name of VisionOS.

Suggestions how to proceed with this failure?

(I'm gonna push fixes to the linting errors next.)

lynchsft commented 1 month ago

I believe all the linting errors have been resolved. :)

lynchsft commented 1 month ago

The Jazzy warnings should be handled now. All that remains is the visionOS simulator on macOS-14. See above comment for error message. Suggestions?

lynchsft commented 1 month ago

I asked xcodebuild to download this missing runtime. As this takes about ~3 minutes in each run, I also parallelized the cocoa pods platforms.

I think all the checks should pass now. :)

lynchsft commented 2 weeks ago

I apologize. Very belatedly I realize that I should have PR'ed this onto my fork before PR''ing it here. This is the same changeset/branch passing in my fork: https://github.com/lynchsft/Yams/pull/3

Ready for review. 🤦🏼‍♀️

jpsim commented 1 week ago

Thank you very much for the PR, Adora and for fixing the unrelated CocoaPods CI issue.

I'll be taking a close look at this soon.