search

jpsingleton / Huxley2

A cross-platform JSON proxy for the GB railway Live Departure Boards SOAP API
https://huxley2.azurewebsites.net
European Union Public License 1.2
51 stars 74 forks source link

Added support for searching for Train, Bus and Ferry services for Staff API queries #6

Closed lukeid123 closed 2 years ago

lukeid123 commented 3 years ago

Defaults to "PBS" to search for all three types in one query, or can filter using ?services=B (for bus services)

jpsingleton commented 3 years ago

Thanks for putting this together and working out the undocumented way the options can be combined! I'm undecided if this should be a user provided value or just hard-coded to match the public web service behaviour. I think the API could be improved from what Darwin offers and in any case the Huxley docs should be updated to match. I'll have a think over the next few weeks and put something together, but input appreciated. Thanks again.

lukeid123 commented 3 years ago

No worries. Obviously you need to balance between consistency with Darwin verus introducing improvements, but I do think it helps reduce the friction when using public and staff versions. In any case, noting it in the documentation can at least make it easier for users to opt-in to.

jpsingleton commented 2 years ago

I've fixed this bug in v2.0.1 but thanks for putting this PR together.