search

jpswalsh / academicons

An icon font for academics
https://jpswalsh.github.io/academicons
790 stars 102 forks source link

zip file as part of the source #12

Closed nschloe closed 8 years ago

nschloe commented 8 years ago

I noticed that commit 0bc9db8390e114b3de44301e8248d2fd5ef9c537 moved zipped file of the version controlled content into version control. This is generally not advised because:

  1. The contents of the file are already contained in the tree.
  2. Binary files are poorly handled by vcs.

Creating a zip file is rather done as a post processing step. For example, you will notice that GitHub provides nice downloads of the release tags https://github.com/jpswalsh/academicons/releases.

Moreover, I see in the commit history https://github.com/jpswalsh/academicons/commits/master lots of entries like "removed v1.*". It is however not necessary to explicitly remove a version. The general scheme would be that you develop your code in, e.g., the folder fonts, and tag a commit with 1.6 whenever you think it's ready. No need to keep separate folders for separate releases or anything.

jpswalsh commented 8 years ago

Thanks. I've followed your advice.