Smaller "1" tabular figure looks funny

[ltguillaume]

I'm trying to use Barlow in https://github.com/ltGuillaume/MusicFolderPlayer, thus I'm really happy that the tabular figures were added (https://github.com/jpt/barlow/issues/27). For smaller font sizes, the "1" does seem to be off, though (tested the .woff in Firefox and Chromium). The angle seems strange and it's not as sharp as it should be, don't you agree?

[jpt]

@ltGuillaume The angle might be a little off. Although to be honest it's also possible the numerals need to be re-drawn entirely. I'll keep this issue open for now, but may close it in the future in favor of an issue that addresses all of the numerals. I'll take a look at the "1" up close as time allows. Thanks for bringing this to my attention!

[ltguillaume]

Cool! Thanks for the quick reply!

[ltguillaume]

By the way, I think most numerals are just fine. It's just that the "1" looks odd.

Apart from that, I can only see that imho the "[" is too far from the next character, and the "]" too far from the previous (it looks like there's an entire "space" character between).

[ltguillaume]

@jpt For now, I've modified these 5 characters in two of the font's variations (Regular, Semi Condensed Regular .woff): tabular 1, and the spacing for (, ), [, and ].

Of course I've given proper credits to you in the README, but I want to be sure I do everything right license-wise. According to https://github.com/jpt/barlow/blob/master/OFL.txt the license strings inside the file suffice ("human-readable headers or in the appropriate machine-readable metadata fields within text or binary files"), so only the following remains:

No Modified Version of the Font Software may use the Reserved Font Name(s) unless explicit written permission is granted by the corresponding Copyright Holder.

So, do I need to change the font's name for those 5 modifications, or do I get your blessing? ;) https://github.com/ltGuillaume/MusicFolderPlayer

Thanks in advance and boy, does a font have its impact on a visual style, I love it!

[jpt]

Hi @ltGuillaume

You don't need to change the font's name, and you don't need my blessing :) The OFL is a bit confusing on the point of Reserved Font Names; if there's no reserved name specified (as is the case with Barlow), there is no requirement around the name. (IIRC, it's common practice for Reserved Font Names to be mentioned at the top of a font's associated OFL.txt file.) So you should be good to go, as long as any derivative font also carries the OFL as its license.

I'm curious to see your changes -- if you've made an improvement to Barlow, pull requests are always welcome :)

[ltguillaume]

Thanks for the response!

Well, I just changed the .woff files directly, so that won't really qualify for a pull request.

[ltguillaume]

[jpt]

this is fixed in 1.5, lol took a while. https://github.com/jpt/barlow/tree/1.5

[jpt]

there are new binaries in the branch now