search

jptrrs / HumanResources

A technology overhaul for RimWorld
MIT License
17 stars 12 forks source link

Unable to store books in bookshelves #165

Closed 2020jji closed 2 years ago

2020jji commented 2 years ago

I wanted to move my bookshelf to a new location, but when I uninstalled the shelf, the books popped out, now it's impossible to move them back on the shelves.

RimWorldWin64_0FvO1zUQUa

Here's my log: https://gist.github.com/HugsLibRecordKeeper/865d44cfc36a96b8c9779617d0c229f7

2020jji commented 2 years ago

Figured it out! It was a conflict with "Favorites!".

2020jji commented 2 years ago

Never mind, seems like the issue still persists...

2020jji commented 2 years ago

Finally figured out the incompatible mod! It was "Pick Up And Haul"...

jptrrs commented 2 years ago

Hi. It seems that's due to some change they made on their last update. Someone made this recommendation on our steam page, maybe it helps: "For people having issues with Pick up and haul - if you are using While you're up / PUAH+ - go to while you're up settings and deselect "Use and improve Pick up and haul". It should now allow you to put books on the bookshelf. I could even enable it back again and pawns could still put books in afterwards. "

2020jji commented 2 years ago

Just tried it out and it's perfect now! Thanks, and I love this mod!

modulozero commented 2 years ago

Hey, FYI, this doesn't seem to work for me :( Worse, if I ever manage to put the book on the shelf (it seems to happen if the pawns don't find anything else to haul at the same time) the entire catalog disappears, and after save & reload, the entire bookshelf will be gone. This does not count as destruction - I still have the technologies from the bookshelf, they just no longer exist as books.

See also my gist

modulozero commented 2 years ago

For what it's worth, it doesn't seem to be an issue if only While You're Up is present - but PUAH seems sufficient. Unfortunately the issue is tricky to reproduce - it seems to require the PUAH mechanics to activate (i.e. take things to different storages at once), but sometimes the pawn will drop the book when just carrying the book - other times it works as it should.

I think a satisfactory fix would be preventing PUAH for working on books at all - unfortunately, I have no idea how to make a PR that can do that within the amount of time I have :(

jptrrs commented 2 years ago

Let me know I you find a reliable way to reproduce the issue, bc I can't.

modulozero commented 2 years ago

I'll try to reproduce it, though probably not immediately - a bit too brain-drained to do proper triage right now :(