jptrrs / SoftWarmBeds

A bed expansion for RimWorld.
https://steamcommunity.com/sharedfiles/filedetails/?id=1713295858
MIT License
0 stars 8 forks source link

Update to 1.4 #24

Closed Daniel-Wedemeyer closed 3 months ago

Daniel-Wedemeyer commented 1 year ago

Hey JPT, I really love SoftWarmBeds, and saw that you haven't been actively maintaining your mods for 1.4, so I updated it myself. The changes look like much, but it's really not: Code-wise, it's:

Defs-wise, it's:

All other changes are just copying folders etc.

I saw in code that blankets are a thing - But they haven't ever worked, have they? At least I haven't seen them ingame. If they were supposed to work, let me know.

Feel free to publish the update under your name, no acknowledgement of my work needed.

waffletacos commented 1 year ago

Hello,

Any chance you would upload this to the Steam Workshop as an unofficial fork since so many people are already trying to find it? It would help with reporting issues. So far it looks like Biotech needs a patch for Cribs which is easy. The insulation stat doesn't seem to work at all now. Also, the blankets have never worked.

I'm pretty sure the original mod author is gone and you can always remove it if they update. It would really help.

Thank you for your time.

gaogzs commented 1 year ago

Hey JPT, I really love SoftWarmBeds, and saw that you haven't been actively maintaining your mods for 1.4, so I updated it myself. The changes look like much, but it's really not: Code-wise, it's:

  • JPTools to .NET Framework 4.8 for compatibility with core methods
  • Adding an empty implementation of a new interface method of IStorageSettingsParent. Most internal implementations are empty, too.

Defs-wise, it's:

  • Changing Patches to correctly interact with changed defs of bed furniture. Comps are now not extended directly (because in vanilla, beds don't have comps anymore), but either added or extended using a ConditionalOperation for mod compatibility.

All other changes are just copying folders etc.

I saw in code that blankets are a thing - But they haven't ever worked, have they? At least I haven't seen them ingame. If they were supposed to work, let me know.

Feel free to publish the update under your name, no acknowledgement of my work needed.

Same, would you consider uploading your fork to the steam workshop since JPT has been relatively inactive?