search

jpuri / draftjs-to-html

Library for converting Draftjs editor content state to HTML
MIT License
321 stars 143 forks source link

change strong to b #27

Closed whaus7 closed 6 years ago

jpuri commented 6 years ago

Hey @whaus7 , strong is also a valid tag for bold text. Any specific reason for preferring b.

whaus7 commented 6 years ago

Hey jPuri! Stupid bbedit for php supposedly doesn't like im not a backend guy so I didn't feel like messing around with the bbedit side

On Fri, Nov 10, 2017 at 12:37 PM, Jyoti Puri notifications@github.com wrote:

Hey @whaus7 https://github.com/whaus7 , strong is also a valid tag for bold text. Any specific reason for preferring b.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jpuri/draftjs-to-html/pull/27#issuecomment-343552289, or mute the thread https://github.com/notifications/unsubscribe-auth/ACjcNeYyv8JzZrEy3hO8C9xSnSK85m5zks5s1JfjgaJpZM4QXDlk .

jpuri commented 6 years ago

Ah I see, I would prefer to make this configurable to select tag for a style. I would be open to a PR for this. Or I will make this change myself as I get time. Thanks for bringing up this requirement.

whaus7 commented 6 years ago

Awesome! I was going to do a PR for that and then delete these packages I published. I was just forking and publishing for 2 reason. 1. Ive never published a package before on NPM and wanted to learn. And 2. Just needed a quick fix. Wasn't sure how responsive you would be. When I get some time this week ill try to make a PR for the config settings. But please dont be too harsh! I'm just starting to get into the open source scene. Been a consuming mole rat for the longest time

On Sun, Nov 12, 2017 at 12:19 PM, Jyoti Puri notifications@github.com wrote:

Ah I see, I would prefer to make this configurable to select tag for a style. I would be open to a PR for this. Or I will make this change myself as I get time. Thanks for bringing up this requirement.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jpuri/draftjs-to-html/pull/27#issuecomment-343756196, or mute the thread https://github.com/notifications/unsubscribe-auth/ACjcNWGm0McMXwlhSlwyYfpqf1Y2EqlTks5s1zalgaJpZM4QXDlk .