search

jpuri / react-draft-wysiwyg

A Wysiwyg editor build on top of ReactJS and DraftJS. https://jpuri.github.io/react-draft-wysiwyg
MIT License
6.41k stars 1.16k forks source link

Warning: onDownArrow, onTab, onUpArrow has been deprecated #853

Open annammarri opened 5 years ago

annammarri commented 5 years ago

Hi, thank you so much for this tool, it's great! When I run the editor, I can see 3 warnings in my console:

  1. Supplying an onDownArrow prop to DraftEditor has been deprecated. If your handler needs access to the keyboard event, supply a custom keyBindingFn prop that falls back to the default one (eg. https://is.gd/RG31RJ).
  2. Supplying an onTab prop to DraftEditor has been deprecated. If your handler needs access to the keyboard event, supply a custom keyBindingFn prop that falls back to the default one (eg. https://is.gd/RG31RJ).
  3. Supplying an onUpArrow prop to DraftEditor has been deprecated. If your handler needs access to the keyboard event, supply a custom keyBindingFn prop that falls back to the default one (eg. https://is.gd/RG31RJ).

and I have these versions on my package.json: "react": "^16.3.2" "react-dom": "^16.3.2" "react-draft-wysiwyg": "^1.13.2" "draft-js": "^0.11.0" "draftjs-to-html": "^0.8.4"

Does somebody know What to do here? I really appreciate your help!

BannukDE commented 5 years ago

Update got published from draft.js 7 days ago. You could downgrade to 10.5 if you have issues other then deprecation warnings or do not want your console overflow while developing. I am looking for a long term fix as well.

rinkisingh8181 commented 5 years ago

@jpuri

Any suggestions with this one?

volkanongun commented 5 years ago

+1

aderbas commented 4 years ago

+1

vrbarros commented 4 years ago

+1

wamujlb commented 4 years ago

@annammarri you can use my fork. I updated it: https://github.com/quriobot/react-draft-wysiwyg/tree/qb-changes

sahiljaidka224 commented 4 years ago

Hi, Please fix this or provide a resolution. :/

sahiljaidka224 commented 4 years ago

+1

Krknv commented 4 years ago

+1

hivanreyes commented 4 years ago

+1

sahiljaidka224 commented 4 years ago

Hey guys, Downgrade your react-draft libraries. "draft-js": "^0.10.5", "draftjs-to-html": "^0.8.4", "html-to-draftjs": "^1.4.0", "react-draft-wysiwyg": "^1.13.2",

juanlanus commented 4 years ago

Is there any work being done towards upgrading this to consume DraftJS 0.11 instead of 0.10? Because this is the real solution for this issue. @wamujlb has a fork, is it possible to merge it?

ferrao commented 4 years ago

I guess the real problem is #879 :(

sahiljaidka224 commented 4 years ago

@ferrao by downgrading you can ignore these warnings, please don't down vote if you don't know

juanlanus commented 4 years ago

As @ferrao said, #879 is at the root of the problem. Unless @jpuri passes the flag to somebody else ...

ferrao commented 4 years ago

@ferrao by downgrading you can ignore these warnings, please don't down vote if you don't know

I downvoted in the sense that I do not think that is the solution for the problem. At most, that is a temporary workaround..

jpuri commented 4 years ago

react-draft-wysiwyg@1.14.1 has the change.