jpw1991 / chebs-necromancy

Cheb's Necromancy adds Necromancy to Valheim via craftable wands and structures. Minions will follow you, guard your base, and perform menial tasks.
The Unlicense
10 stars 4 forks source link

Skeletons not mining Silver #109

Closed jdalfonso4341 closed 1 year ago

jdalfonso4341 commented 1 year ago

Describe the bug

The miner Skeletons are not mining silver

To Reproduce (if applicable)

Steps to reproduce the bug. For example:

  1. Clear silver vein
  2. raise ground around the solver, so the skeletons don't go after the stones in the immediate area
  3. Summon miner skeletons

Expected behavior (if applicable)

Mine Silver

Screenshots (if applicable)

Screenshot (1210)

suRedLance commented 1 year ago

The same happens for any kind of ore. Seems like they only look for normal rocks and once there are none in their radius they just freeze in place. 2023-03-02_13-16

jpw1991 commented 1 year ago

Thanks for the feedback. I'll look into this soon

CW-Jesse commented 1 year ago

@jpw1991 Any chance this would be fixed using the new FindClosest? Woodcutters also not seeing nearby wood. Feels like the neckro problem all over again.

jdalfonso4341 commented 1 year ago

Dam adorable Neckros. They are too cute not to use.

jpw1991 commented 1 year ago

Hi @suRedLance & @jdalfonso4341 can you please try adding the following to the config for the miner ores list and seeing if it fixes the problem for silver:

For copper and other ores, hmm. I am still not sure.

Any chance this would be fixed using the new FindClosest? Woodcutters also not seeing nearby wood. Feels like the neckro problem all over again.

Yeah it would help I think @CW-Jesse

jpw1991 commented 1 year ago

Seems like MineRock_Tin is the name for the tin. It's hard to find them all

jpw1991 commented 1 year ago

Ah damn it. MineRock_Tin has a different mask

jpw1991 commented 1 year ago

Alright so they're mining Tin and Obsidian now in my unreleased test version. They are still not mining silver and copper. I'm not sure yet why that is.

@CW-Jesse I also refactored to make use of that FindClosest function

suRedLance commented 1 year ago

I have tried out using MineRock_Tin and MineRock_Copper too (using the documentation from Jotunn's) but it doesn't change anything. I feel like this is more of an AI problem than anything. Next few days I'll take the FindClosest version for a spin, and see if it works.

suRedLance commented 1 year ago

Same thing on 2.3.0, just checked.

jpw1991 commented 1 year ago

Same thing on 2.3.0, just checked.

Please try 2.3.3

suRedLance commented 1 year ago

Please try 2.3.3

Works on Tin now, but they still ignore copper, even when standing on top of a full vein.

jpw1991 commented 1 year ago

This one really isn't making sense to me. Technical "proof" that it should be able to mine copper:

image

Because it is no different from tin:

image

I will probably figure it out eventually, but it's a tough cookie...

jpw1991 commented 1 year ago

image

Success! I got it! Just gotta polish it up some,t hen I will release