jpw1991 / chebs-necromancy

Cheb's Necromancy adds Necromancy to Valheim via craftable wands and structures. Minions will follow you, guard your base, and perform menial tasks.
The Unlicense
10 stars 4 forks source link

2.1.1: Add bonus minions for necromancy level if configured to use limits #117

Closed jpw1991 closed 1 year ago

jpw1991 commented 1 year ago

Compiled: here

Testing:

Please tick the box as you complete each test segment.

CW-Jesse commented 1 year ago

There's a divide by zero error when either MinionLimitIncrementsEveryXLevels is set to 0.

jpw1991 commented 1 year ago

There's a divide by zero error when either MinionLimitIncrementsEveryXLevels is set to 0.

Aw man, could've sworn I accounted for that possibility... haha. Thanks

CW-Jesse commented 1 year ago

Oh wait, you did. It was just because you checked one and used the other, which means it will be resolved with https://github.com/jpw1991/chebs-necromancy/pull/117#discussion_r1124113434

jpw1991 commented 1 year ago

Oh wait, you did. It was just because you checked one and used the other, which means it will be resolved with #117 (comment)

Ah ok, phew. Thanks for the great and comprehensive testing