jpw1991 / chebs-necromancy

Cheb's Necromancy adds Necromancy to Valheim via craftable wands and structures. Minions will follow you, guard your base, and perform menial tasks.
The Unlicense
10 stars 4 forks source link

make dll bundle #171

Closed jpw1991 closed 1 year ago

jpw1991 commented 1 year ago

Description

Bundle all into DLL to make it easier for some ppl.

Problems

There's a problem with DLL bundling with the future in mind. Allow me to explain:

Mod Version Assets Size
Cheb's Necromancy 2.X.X ~22mb
Cheb's Necromancy 3.X.X ~27mb

Adding the Cheb's Mercenaries mod stuff to the assets bundle added about 5mb. In the future, as more variants get added like Druidry, Demonology, so on and so forth, this can be expected to grow and grow.

Separate

Attention: as of 3.0.6, ChebsValheimLibrary.dll is merged into the ChebsNecromancy.dll, meaning that only the assets file is left separate.

If left separate, the player can have one copy of the asset bundle on their system and the DLLs will share it:

image

Benefits

Drawbacks

Bundled

If bundled, each bundle is its own box and requires a copy of everything inside it to work:

image

Benefits

Drawbacks

Future Scenario

Imagine in the future when we have not only Necromancy and Mercenaries, but also Druidry, Demonology, and Golem Maker. Let's theorize that the new mods have resulted in a 75mb assets file.

Separate

If installed using the separate method, the total file size of all 5 mods including their DLLs will be less than 80mb.

Bundled

If installed using the bundle method, the total file size of all 5 mods will be at least 375mb.

jpw1991 commented 1 year ago

Ugh, the final nail in the coffin for this bundling stuff is it ruins the cross-compatible nature of my mods when installed together. For more detail, please read here where the discord discussion took place but I'm going to have to disappoint and deny this request. I'm sorry.