jpw1991 / chebs-necromancy

Cheb's Necromancy adds Necromancy to Valheim via craftable wands and structures. Minions will follow you, guard your base, and perform menial tasks.
The Unlicense
10 stars 4 forks source link

WardisLove incompatibility with non-commandable summons (necros, lumberjacks, etc) #177

Closed Zudakas closed 1 year ago

Zudakas commented 1 year ago

Describe the bug

Incompatibility with WardIsLove mod - Push Creatures out of ward area setting. If turned on, all non-commandable summons (Neckros, Lumberjacks, Miners, etc) will be pushed from the ward area, including through walls. If creature damage is turned on, they are also damaged.

To Reproduce (if applicable)

Install WardIsLove mod ( https://valheim.thunderstore.io/package/Azumatt/WardIsLove/ ) and turn on Push Creatures from Ward Area, as well as Damage Creatures within Ward Area.

Summon non-commandable summons, or place summoning pylons for Neckros (Not sure about the bats, leeches, or the others, but assumably they are also affected).

Expected behavior (if applicable)

Summons behave as intended, unaffected by the ward (

Screenshots (if applicable)

Desktop

jpw1991 commented 1 year ago

Hi Zudakas,

Thanks for opening the issue. Unfortunately, I cannot apply Tameable to the Neckros and Worker minions because, especially in the case of the Neckro, it will mess up their functionality.

Possible Solutions

Faction check

Azumatt checks not only Tameable but also the creature's faction because the minions belong to the Player faction - even if they have no Tameable component on them.

Exceptions List

Maybe certain creatures can be exempted via configs and won't be affected by the ward. Something like Exemptions = ChebGonaz_NeckroGatherer,ChebGonaz_SkeletonWoodcutter,ChebGonaz_SkeletonMiner

Zudakas commented 1 year ago

Ok, wasn't sure if it was an easy fix on your end or not, I'll go pester them :)

jpw1991 commented 1 year ago

Sounds good haha. You can point them here and I'll help, if I can, to solve the problem

jpw1991 commented 1 year ago

As of the newest version, only the Neckro should be affected by the ward. The workers count as tames