jpw1991 / chebs-necromancy

Cheb's Necromancy adds Necromancy to Valheim via craftable wands and structures. Minions will follow you, guard your base, and perform menial tasks.
The Unlicense
10 stars 4 forks source link

4.4.0: pushing WIP code for phylactery check RPC #244

Closed jpw1991 closed 7 months ago

CW-Jesse commented 7 months ago

Gotta remove Phylacteries from the static list in OnDestroy or similar.

CW-Jesse commented 7 months ago

Would it be better to do checks for fueled Phylacteries when the player is supposed to die instead of constantly updating it? Make them invincible and then kill them if one isn't available?

jpw1991 commented 7 months ago

Would it be better to do checks for fueled Phylacteries when the player is supposed to die instead of constantly updating it? Make them invincible and then kill them if one isn't available?

I am concerned that, due to latency or whatever else, checking on the event of death might be too slow and it may be better to have the information in advance rather than waiting for a server response. But yeah maybe you're right.

It currently is supposed to work like:

Edit: accidently closed PR when hitting enter lol

jpw1991 commented 7 months ago

@CW-Jesse code review still welcome on this but tested to work on both single player and dedicated server