search

jpw1991 / chebs-necromancy

Cheb's Necromancy adds Necromancy to Valheim via craftable wands and structures. Minions will follow you, guard your base, and perform menial tasks.
The Unlicense
10 stars 4 forks source link

Reorganize harmony patches #85

Closed jpw1991 closed 1 year ago

jpw1991 commented 1 year ago

I moved harmony patches out of BasePlugin.cs and gave each patch a class-specific file. This just needs some generic testing to ensure that none of the patches broke.

Can you please investigate if it's possible to wrap the entire file in pragmas? eg.

using bla bla bla

#pragma warning disable IDE0051 // Remove unused private members
#pragma warning disable IDE0060 // Remove unused parameter

class 1
{ bla bla}

class 2
{bla bla}

#pragma warning restore IDE0060 // Remove unused parameter
#pragma warning restore IDE0051 // Remove unused private members

If it works in your IDE, that'd be nice. You can just add and commit it.

Jetbrains Rider uses:

// ReSharper disable InconsistentNaming
// ReSharper disable UnusedParameter.Local
jpw1991 commented 1 year ago

This got merged into master a while back