search

jpxthu / EPGP-Classic

EPGP for World of Warcraft Classic
MIT License
6 stars 12 forks source link

On Titan toolbar error on mouseover #50

Closed rbpaiett closed 4 years ago

rbpaiett commented 4 years ago

When doing mouseover on icon on the Titan toolbar I get the following error:

2x AceLocale-3.0-6: EPGP: Missing entry for 'Decay=%s%% BaseGP=%s MinEP=%s Extras=%s%%' EPGP-Classic\modules\ldb.lua:41: in function func' TitanClassic\LDBToTitanClassic.lua:185: in functionTitanLDBSetTooltip' TitanClassic\LDBToTitanClassic.lua:249: in function <TitanClassic\LDBToTitanClassic.lua:247>

Am I missing something?

jpxthu commented 4 years ago

https://github.com/jpxthu/EPGP-Classic/blob/master/modules/ldb.lua#L41

L["Decay=%s%% BaseGP=%s MinEP=%s Extras=%s%%"]

There is no such an item in localization. I think there is no need to localize it. Try to modify it to a string if you are calling this file. If it works, create a PR please. Thanks!

jpxthu commented 4 years ago

Please try this locally: https://github.com/jpxthu/EPGP-Classic/pull/51

rbpaiett commented 4 years ago

Is this something I need to be doing or am I just being given the latest info? I don't understand much about what you're talking about.

jpxthu commented 4 years ago

Never mind. I just released a new version. Please update and have a try when v1.5.5 is available.

rbpaiett commented 4 years ago

Works just fine, thanks!