search

jpype-project / jpype

JPype is cross language bridge to allow Python programs full access to Java class libraries.
http://www.jpype.org
Apache License 2.0
1.12k stars 183 forks source link

Windows locale #1174

Closed Thrameos closed 6 months ago

Thrameos commented 9 months ago

This is an attempt to make JPype work when there are international characters in the path name. Currently does not appear to make a significant difference because the JVM itself does not support it on the tested system.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.44%. Comparing base (904fc43) to head (2c0420e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1174 +/- ## ========================================== - Coverage 87.45% 87.44% -0.01% ========================================== Files 113 113 Lines 10236 10236 Branches 4057 4057 ========================================== - Hits 8952 8951 -1 Misses 692 692 - Partials 592 593 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thrameos commented 9 months ago

@marscher This is meant to address #1111 but as I don't have a system that supports international paths for the JVM I can't really tell if it fixes anything more than moving the failure point. If the international testers do find it to fix the problem, I will complete this PR with the usual changelog entry, ask for a review, etc.

marscher commented 6 months ago

Thanks at lot and sorry for the delay!