Closed alexrashed closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.44%. Comparing base (
653ccff
) to head (31339e3
). Report is 157 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@marscher are you around? There have been a number of items requiring update recently. If you aren't available for review I will likely have to self review and get the ball rolling towards a release.
If you aren't available for review I will likely have to self review and get the ball rolling towards a release.
I can step up for some review. Particularly on the Python infra side of things. Feel free to ping me.
FWIW, I think this PR is good to go as it is.
Thanks. I will start merging. I will also need to finish the patch/kludge for 3.13 before we release.
Sorry for being not available for so long. Thanks for the patch. I think this is pretty straight forward.
Motivation
With
setuptools==72.0.0
, the test command was removed after being deprecated for a long time. This completely breaks the installation of any packages using the test command, including JPype. See https://github.com/pypa/setuptools/issues/4519 for other issue reports. This PR fixes JPype to be compatible with setuptools 72+ again. Fixes https://github.com/jpype-project/jpype/issues/1205.Changes
setup.py test
was not used in CI anymore, so in terms of usage, this PR only adjusts one line in the docs.Testing
Before:
With the code in this PR: