search

jpzhu / git-repo

Automatically exported from code.google.com/p/git-repo
Apache License 2.0
0 stars 0 forks source link

Certficate handling Python2.7.9 #197

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Affected Version: All on Python2.7.9
Environment: OSX

What steps will reproduce the problem?
1. Have python2.7.9
2. Run repo upload with review_url pointing at a server with a self signed 
certificate

What is the expected output? What do you see instead?

Expect repo to upload the commits. Instead the following error:

[FAILED] PROJECTNAME  BRANCH
       (REVIEW_URL: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581)>)

Original issue reported on code.google.com by dylanwy...@gmail.com on 13 Apr 2015 at 4:02

GoogleCodeExporter commented 9 years ago 
Looks like when repo uses urlopen() it just passes the url. If I've defined a 
certificate or certificate directory in my gitconfig these should be passed as 
arguments to allow repo to interact with trusted self-signed certificates. 

Caused by https://www.python.org/dev/peps/pep-0476/

Previously urllib2 would ignore invalidate certificates.

Original comment by dylanwy...@gmail.com on 13 Apr 2015 at 4:04