jpzk / mockedstreams

Scala DSL for Unit-Testing Processing Topologies in Kafka Streams
Apache License 2.0
187 stars 24 forks source link

Update to Kafka 1.1.0 #28

Closed Eddpt closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files           1        1           
  Lines          45       45           
  Branches        2        2           
=======================================
  Hits           43       43           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d699340...71edab1. Read the comment docs.

schmiegelow commented 6 years ago

It seems that org.apache.kafka.test.ProcessorTopologyTestDriver has disappeared from Kafka 1.1.0, but this library relies on it to create a Fake topology for tests. Did you verify this?

Eddpt commented 6 years ago

It looks like it was removed on this commit, so ProcessorTopologyTestDriver no longer exists in branch trunk, but it still existed at the time 1.1.0 was released, so it should be ok to update to 1.1.0.

What do you think?

efeller commented 6 years ago

@jpzk Would be great if we could get this merged. ProcessorTopologyTestDriver seems to exist in 1.1 branch (https://github.com/apache/kafka/blob/1.1/streams/src/test/java/org/apache/kafka/test/ProcessorTopologyTestDriver.java) and 1.1.0 tag (https://github.com/apache/kafka/blob/1.1.0/streams/src/test/java/org/apache/kafka/test/ProcessorTopologyTestDriver.java)

Thanks.

jpzk commented 6 years ago

LGTM, i will add it to the release branch