jqlang / jq

Command-line JSON processor
https://jqlang.github.io/jq/
Other
29.59k stars 1.54k forks source link

chore: fix some typos in comments #3096

Closed goodactive closed 2 months ago

goodactive commented 2 months ago

We already fixed some stuff in vendored code (decnumber) in #3060 so i guess it's fine

Thanks for the replay.

itchyny commented 2 months ago

But, did you try sending the patch to the original author? It is recommended to send corrections to the upstream in general, otherwise these changes may be reverted when we follow the upstream for any security reasons. The E-mail address is written in the first comment in each file of decNumber.

emanuele6 commented 2 months ago

Yes, none of those typos are in jq code; the one in src/util.c is from res2001/strptime, and the other ones are all from decNumber. It would make a lot more sense to report those typos upstreams, since we generally do not care about reading the content of those files, and we don't want to modify them unless we have to...