Closed ujaehrig closed 2 weeks ago
jqnatividad
commented
1 month ago Thanks @ujaehrig for the report.
I can confirm that this is a bug that may have been inadvertently introduced when I used a tagged release of polars with breaking API changes.
This will be fixed with the next release which should be by this weekend.
Until then, you can compile from source. https://github.com/jqnatividad/qsv?tab=readme-ov-file#option-4-compile-from-source
dsferruzza
commented
2 weeks ago Hi!
Not sure if this is considered as fixed, but I still have one error when compiling 0.129.1 in Ubuntu 22.04.4 LTS and Rust 1.79.0:
error[E0599]: no variant or associated item named `Right` found for enum `polars::prelude::JoinType` in the current scope
--> /home/d/.cargo/registry/src/index.crates.io-6f17d22bba15001f/qsv-0.129.1/src/cmd/joinp.rs:296:32
|
296 | join.run(JoinType::Right, validation, false)
| ^^^^^ variant or associated item not found in `JoinType`Any idea?
jqnatividad
commented
2 weeks ago For now, @dsferruzza , you'll have to do the workaround of compiling from source.
After polars 0.41.3 was released, JoinType::Right was supported and I updated patch.crates.io in Cargo.toml to take advantage of it.
However, it seems cargo install does not use the patch.crates.io entry for polars, which cargo build does.
dsferruzza
commented
1 week ago OK so at some point Polars will release a new version that includes this feature and you will be able to remove the patch.crates.io entry, is that correct?
jqnatividad
commented
1 week ago That's correct.
However, given the torrid development pace of polars, the patch.crates.io for polars is likely to remain as I often update it to point upstream when there are major unreleased features and fixes.
Polars has quite good test coverage and their release cycle for python-polars (which uses unreleased rust-polars like qsv) is far more frequent than their rust-polars releases. So it gives me confidence its safe to do this.
Just the same - I expanded the explanation in the README.
https://github.com/jqnatividad/qsv/commit/c220c55b03b34c5dc9d92f1ea5b83f313bbd916d
Build with cargo fails When executing
cargo install qsv --locked --features all_featuresI get the following error: https://gist.github.com/ujaehrig/6d9d8cad83fea209922cacd437b9f0e7Desktop: