jqnatividad / qsv

Blazing-fast Data-Wrangling toolkit
https://qsv.dathere.com
The Unlicense
2.52k stars 71 forks source link

Update deb package #2226

Open tino097 opened 1 month ago

tino097 commented 1 month ago

We will include qsv, qsvdp, qsvlite in the deb package

tino097 commented 1 month ago
   --> src/cmd/sortcheck.rs:115:9
    |
115 |         record_count = if show_progress {
    |         ^^^^^^^^^^^^
    |
    = help: maybe it is overwritten before being read?
    = note: `#[warn(unused_assignments)]` on by default

error[E0384]: cannot assign twice to immutable variable `record_count`
   --> src/cmd/sortcheck.rs:126:9
    |
115 | /         record_count = if show_progress {
116 | |             let count = util::count_rows(&rconfig)?;
117 | |             util::prep_progress(&progress, count);
118 | |             count
...   |
121 | |             0
122 | |         };
    | |_________- first assignment to `record_count`
...
126 |           record_count = 0;
    |           ^^^^^^^^^^^^^^^^ cannot assign twice to immutable variable
    |
help: consider making this binding mutable
    |
105 |     let mut record_count;
    |         +++

For more information about this error, try `rustc --explain E0384`.
warning: `qsv` (bin "qsv") generated 1 warning
error: could not compile `qsv` (bin "qsv") due to 1 previous error; 1 warning emitted
cargo-deb: build failed

After merging master in the branch, when im running cargo deb im getting this error

jqnatividad commented 1 month ago

This is because each binary variant requires different features:

Can we have multiple cargo-deb sections for each?

tino097 commented 1 month ago

I will need to test it