jqr / heroku_san

Helpful stuffs for Heroku.
MIT License
583 stars 99 forks source link

changing BUILDPACK_URL doesn't update app configuration on heroku #163

Open matthargett opened 10 years ago

matthargett commented 10 years ago

result: after changing our BUILDPACK_URL in the heroku.yml, our heroku app was still using autodetect.

expected result: heroku_san should either update the heroku configuration, or provide a warning message that the BUILDPACK_URL does not match the application, when deploying.

our heroku.yml: production: app: cases-render-service-prod config: NODE_ENV: production BUILDPACK_URL: https://github.com/ddollar/heroku-buildpack-multi.git staging: app: cases-render-service-staging config: NODE_ENV: production BUILDPACK_URL: https://github.com/ddollar/heroku-buildpack-multi.git

kmayer commented 10 years ago

When you run heroku config (NOT rake heroku config, use Heroku's CLI) does the new URL show up? If not, did you run rake heroku config after changing the url in the config file? Setting config vars is an "expensive" API call to Heroku, so it is not done automatically by heroku_san. After looking at Heroku's documentation for BUILDPACK_URL, it is just another config var, so if it is set, it should work. They do mention that you must specify a version in the url, too ( https://devcenter.heroku.com/articles/buildpacks#using-a-custom-buildpack).

On Tue, Feb 11, 2014 at 11:17 AM, Matt Hargett notifications@github.comwrote:

result: after changing our BUILDPACK_URL in the heroku.yml, our heroku app was still using autodetect.

expected result: heroku_san should either update the heroku configuration, or provide a warning message that the BUILDPACK_URL does not match the application, when deploying.

our heroku.yml: production: app: cases-render-service-prod config: NODE_ENV: production BUILDPACK_URL: https://github.com/ddollar/heroku-buildpack-multi.git staging: app: cases-render-service-staging config: NODE_ENV: production BUILDPACK_URL: https://github.com/ddollar/heroku-buildpack-multi.git

Reply to this email directly or view it on GitHubhttps://github.com/fastestforward/heroku_san/issues/163 .

ken@bitwrangler.com | (808) 722-6142 (c)