jquast / blessed

Blessed is an easy, practical library for making python terminal apps
http://pypi.python.org/pypi/blessed
MIT License
1.2k stars 72 forks source link

Fixes and non-critical testing for Python 3.10-dev #177

Closed avylove closed 4 years ago

avylove commented 4 years ago

Travis added support for testing early releases of Python 3.10. Everything works except the version test in __init__.py, which needs to use integers instead of strings in order to support comparison of two digit version elements.

codecov[bot] commented 4 years ago

Codecov Report

Merging #177 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   95.31%   95.32%           
=======================================
  Files           9        9           
  Lines        1004     1005    +1     
  Branches      160      160           
=======================================
+ Hits          957      958    +1     
  Misses         44       44           
  Partials        3        3           
Impacted Files Coverage Δ
blessed/__init__.py 77.77% <100.00%> (+2.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f66e57...29eebce. Read the comment docs.

avylove commented 4 years ago

The main reason for a release is to support downstream testing of 3.10, which is how I found the bug. What do they say about testing? Early and often.

I agree, that code can probably be deleted. There are no downloads for 3.2 and even very few for 3.3. Here are the stats for the last month.

python_version download_count
3.6 95,327
2.7 73,348
3.7 52,873
3.8 52,243
3.5 12,527
3.4 1,111
3.9 90
3.3 48
2.6 8
3.10 3
Total 287,578
avylove commented 4 years ago

Actually, if we do that, we should probably drop 3.2 from the supported versions, but while the net effect is probably nil, that shouldn't be done in a bug release. So I'm thinking just fix it for now and drop 3.2 the next time there's a feature release.

avylove commented 4 years ago

Sorry for the extra commits in master. I think github had a hiccup. I did a squash and merge, but it told me it failed. Then I saw it did a merge without the squash

jquast commented 4 years ago

No problem—best wishes