Closed stefanholek closed 1 year ago
Base: 95.15% // Head: 95.18% // Increases project coverage by +0.03%
:tada:
Coverage data is based on head (
f25692a
) compared to base (7a114c3
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I rebased and consolidated the common code. Then I noticed all the test data was ffff/ffff/ffff
, so I used somes X11 colors instead to make them in range and different values. Out of range values still work, but I don't think it's our place to police that. If the terminal wants to report the values higher than 255, I don't think we care.
@jquast, I think this looks ok to merge. Can you take a look?
Sorry we haven't responded to this sooner.
I think there's too much duplication of code. We should probably pull the try/finally block into its own method, maybe a context manager, since that code is the same in three places except a few variables. Then maybe we can do something like: