Closed avylove closed 2 years ago
Base: 95.36% // Head: 95.50% // Increases project coverage by +0.14%
:tada:
Coverage data is based on head (
e1f94b2
) compared to base (06a8d2e
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Pylint 2.14 The main thing here is changing
width.__index__()
toint(width)
. Pylint complained about the use of a dunder method and as I dug into it, usingint()
is more correct since it will support all the magic methods for coercion to an integer (__int__()
,__trunc__()
, etc). The test is explicitly for__index__()
which exists in older Python versions, but is not invoked byint()
until 3.8, so I limited the test to newer versions.Code Tweaks Pretty much all of these are getting rid of redundant syntax
{...}
instead ofset([...])
if cond
instead ofif not cond
dict.get(item)
instead ofdict.get(item, None)