Closed avylove closed 1 year ago
Base: 95.35% // Head: 95.15% // Decreases project coverage by -0.19%
:warning:
Coverage data is based on head (
204a443
) compared to base (df28567
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
3.12-dev is available now, currently alpha1, and it looks like we're passing.
@jquast Can you approve this or give me access to approve my own PRs? The CI tests have been broken for the last couple months and it would be good to see them green again.
Deprecated pytest-xdist option
Most of the tests are currently broken because pytest-xdist deprecated
looponfail
without an alternative. Since we havefilterwarnings = error
this causes the deprecation warning to be treated as a failure. Rather than pin pytest-xdist or figure out how to filter the deprecation, I thought it was easier to remove it.https://github.com/pytest-dev/pytest-xdist/issues/826
Test Updates
While I was in there, I moved the main test version to 3.10 and added 3.11 and 3.12-dev. 3.12-dev isn't currently available in the pipelines since 3.12 alpha 1 was released 2 days ago, but should be soon. It's tagged as optional.
The optional test syntax also seems to have changed, so I had to add
continue-on-error
. It's buggy in that it will show a success in the Actions view when a optional test fails, but the commit view still shows an X.SupportsIndex
After some back and forth with the Pylint team, I realized using
int(width)
instead ofwidth__index__()
for the formatting methods was actually wrong. The latest Pylint handles this correctly and I added a commit to revert to the previous behavior. Also noticed one of the typing files was using int instead of SupportsIndex, so updated that too.Other Also made a handful of code tweaks, nothing significant.