jquast / blessed

Blessed is an easy, practical library for making python terminal apps
http://pypi.python.org/pypi/blessed
MIT License
1.2k stars 72 forks source link

Drop 3.4 Support #253

Closed avylove closed 1 year ago

avylove commented 1 year ago

Github dropped the Ubuntu 18.04 image we were using to test 3.4 and my distro doesn't have a package for it, so I think it's time to drop support.

If the query is correct, Blessed was only downloaded 509 times for Python 3.4 in the last 6 months.

This should fix the failing CI tests.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (d404d8c) 95.38% compared to head (9bf91b6) 95.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #253 +/- ## ======================================= Coverage 95.38% 95.38% ======================================= Files 9 9 Lines 1018 1018 Branches 215 215 ======================================= Hits 971 971 Misses 43 43 Partials 4 4 ``` | [Impacted Files](https://app.codecov.io/gh/jquast/blessed/pull/253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeff+Quast) | Coverage Δ | | |---|---|---| | [blessed/formatters.py](https://app.codecov.io/gh/jquast/blessed/pull/253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeff+Quast#diff-Ymxlc3NlZC9mb3JtYXR0ZXJzLnB5) | `100.00% <ø> (ø)` | | | [blessed/terminal.py](https://app.codecov.io/gh/jquast/blessed/pull/253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeff+Quast#diff-Ymxlc3NlZC90ZXJtaW5hbC5weQ==) | `98.27% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

avylove commented 1 year ago

Also switched the Codecov uploader to the GitHub Actions one because they dropped the Python one from PyPI.

avylove commented 1 year ago

Also needed to fix a Sphinx config issue and fix paths for tox.

avylove commented 1 year ago

@jquast I think this is ready. Should fix the CI tests

jquast commented 1 year ago

I suppose the code would still theoretically work with 3.4, we just can't test it, just to remind that python_requires can allow older versions of python to install older/compatible versions of blessed

avylove commented 1 year ago

Yeah, no actual code changes, so it should work. Do you think we should exclude 3.0 - 3.4 in python_requires?

jquast commented 1 year ago

Oh it’s fine as it is, just wanted to mention it :)